[
https://issues.apache.org/jira/browse/CASSANDRA-16975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417982#comment-17417982
]
Branimir Lambov commented on CASSANDRA-16975:
---------------------------------------------
On second thought, clearing the reference will bring it to 0, which might
trigger some obsoletion we really don't want to happen to the outputs. In other
words, it's best if the tools exit with a reference to their outputs.
Patch LGTM.
> CompactionTask#runMayThrow should not release new SSTables for offline
> transactions
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-16975
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16975
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Aleksandr Sorokoumov
> Assignee: Aleksandr Sorokoumov
> Priority: Normal
> Fix For: 4.0.x
>
>
> Right now, {{CompactionTask#runMayThrow}} releases new SSTables for offline
> transactions
> ([code|https://github.com/apache/cassandra/blob/f7c71f65c000c2c3ef7df1b034b8fdd822a396d8/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L227-L230]).
> This change was added in CASSANDRA-8962, prior to the introduction of
> lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might
> be undesired and could have just fallen through the cracks.
> To my knowledge, this code does not cause any known bugs solely because
> in-tree tools do not access the SSTables they produce before exiting.
> However, if someone is to write, say, offline compaction daemon, it might
> break on subsequent compactions because newly created SSTables will be
> released.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
