[
https://issues.apache.org/jira/browse/CASSANDRA-16975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422673#comment-17422673
]
Andres de la Peña commented on CASSANDRA-16975:
-----------------------------------------------
[~Gerrrr] I understand that the patch should also be applied to trunk, is this
right? I have prepared a patch for trunk
[here|https://github.com/apache/cassandra/compare/trunk...adelapena:16975-trunk-review],
with CI runs for
[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/936/workflows/0d59df0e-ac26-4c88-afc5-404bf767c033]
and
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/936/workflows/2f4fd070-4fd2-4753-a4e6-2137379f8997].
The runs contain 100 rounds of the new test, just in case.
> CompactionTask#runMayThrow should not release new SSTables for offline
> transactions
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-16975
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16975
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Aleksandr Sorokoumov
> Assignee: Aleksandr Sorokoumov
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Right now, {{CompactionTask#runMayThrow}} releases new SSTables for offline
> transactions
> ([code|https://github.com/apache/cassandra/blob/f7c71f65c000c2c3ef7df1b034b8fdd822a396d8/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L227-L230]).
> This change was added in CASSANDRA-8962, prior to the introduction of
> lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might
> be undesired and could have just fallen through the cracks.
> To my knowledge, this code does not cause any known bugs solely because
> in-tree tools do not access the SSTables they produce before exiting.
> However, if someone is to write, say, offline compaction daemon, it might
> break on subsequent compactions because newly created SSTables will be
> released.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
