[ 
https://issues.apache.org/jira/browse/CASSANDRA-16975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422731#comment-17422731
 ] 

Andres de la Peña commented on CASSANDRA-16975:
-----------------------------------------------

No worries, too many branches :)

Committed to 3.0 as 
[3e6faca572a5ca1de5906b39b8c0a6bf4deb40e9|https://github.com/apache/cassandra/commit/3e6faca572a5ca1de5906b39b8c0a6bf4deb40e9]
 and merged to 
[3.11|https://github.com/apache/cassandra/commit/dcc95492e9b05e1b8ceb3af332d5c0989c7272b0],
 
[4.0|https://github.com/apache/cassandra/commit/c0916d67be25c700e5de93242afa7244c7fbbb02]
 and 
[trunk|https://github.com/apache/cassandra/commit/b6e400d0c3c3f74d17261caaa6388e6c70df322f].

> CompactionTask#runMayThrow should not release new SSTables for offline 
> transactions
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16975
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16975
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Compaction
>            Reporter: Aleksandr Sorokoumov
>            Assignee: Aleksandr Sorokoumov
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> Right now, {{CompactionTask#runMayThrow}} releases new SSTables for offline 
> transactions 
> ([code|https://github.com/apache/cassandra/blob/f7c71f65c000c2c3ef7df1b034b8fdd822a396d8/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L227-L230]).
>  This change was added in CASSANDRA-8962, prior to the introduction of 
> lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might 
> be undesired and could have just fallen through the cracks.
> To my knowledge, this code does not cause any known bugs solely because 
> in-tree tools do not access the SSTables they produce before exiting. 
> However, if someone is to write, say, offline compaction daemon, it might 
> break on subsequent compactions because newly created SSTables will be 
> released.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to