[
https://issues.apache.org/jira/browse/CASSANDRA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431203#comment-17431203
]
Alex Petrov commented on CASSANDRA-17044:
-----------------------------------------
bq. It is used to modify the schema and query the schema by accessing various
parts of the system.
Right, by that logic we may want to rename {{CommitLog}} and {{Memtable}}. I
think this class is responsible for access to Schema, and many methods such as
{{loadFromDisk}} sort of make sense if the class is named {{Schema}} but not
really if it's called {{SchemaManager}}. Overall, I'm -0 on the change, I just
do not see addition of "manager" in the name as an improvement.
Renaming or leaving the name as-is seems like a matter of personal preference
more than anything, so if you strictly insist on renaming it, it's not a
problem but I'd ask to do it outside the scope of this ticket. I've renamed it
back in my review branch for now.
bw. For the noisiness - I purposely did that in a distinct commit where no
other changes were made for the review convenience.
I appreciate you doing that. I (personally) prefer to review patches in their
entirety after reviewing individual commits, since some changes are not
transitively obvious.
> Refactor schema management to allow for schema source pluggability
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17044
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17044
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema
> Reporter: Jacek Lewandowski
> Assignee: Jacek Lewandowski
> Priority: Normal
>
> The idea is decompose `Schema` into separate entities responsible for
> different things. In particular extract what is related to schema storage and
> synchronization into a separate class so that it is possible to create an
> extension point there and store schema in a different way than
> `system_schema` keyspace, for example in etcd.
> This would also simplify the logic and reduce the number of special cases,
> make all the things more testable and the logic of internal classes
> encapsulated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
