[ 
https://issues.apache.org/jira/browse/CASSANDRA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431229#comment-17431229
 ] 

Paulo Motta commented on CASSANDRA-17044:
-----------------------------------------

{quote}"Manager" is one of those words that often means nothing by itself
{quote}
We already adopt the "Manager" suffix in many instances to distinguish the 
object manager class from the actual (generally immutable) object being managed 
(ie. HintsManager (manages Hints), SnapshotManager (manages Snapshots), 
CompactionStrategyManager (manages Compaction Strategies), etc), so it would be 
at the very least inconsistent with other parts of the codebase to have a 
Schema object which *is not* a schema, but manages the schema, so I'm +1 for 
making our codebase more consistent and meaningful by renaming {{Schema}} to 
{{SchemaManager}} (perhaps in a separate ticket to reduce review noise on this 
ticket).
{quote}I'd prefer to remove Duration class and leave just the utility methods 
which implement the conversions we need (and those conversions should convert 
to/from Java's Duration I think).
{quote}
sounds good to me

> Refactor schema management to allow for schema source pluggability
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-17044
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17044
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Cluster/Schema
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>
> The idea is decompose `Schema` into separate entities responsible for 
> different things. In particular extract what is related to schema storage and 
> synchronization into a separate class so that it is possible to create an 
> extension point there and store schema in a different way than 
> `system_schema` keyspace, for example in etcd. 
> This would also simplify the logic and reduce the number of special cases, 
> make all the things more testable and the logic of internal classes 
> encapsulated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to