[ 
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443669#comment-17443669
 ] 

Berenguer Blasi commented on CASSANDRA-17132:
---------------------------------------------

[~e.dimitrova] your '4.0 patch' link point to a compare between _trunk_ and 
your 4.0 PR instead of 4.0 and your 4.0 PR #justfyi

Just a couple comments:
- I _think_ [~dcapwell] was on top of the bootstrap failures and there is some 
umbrella ticket somewhere already?
- The dtest failures on an address already being used I concur they are 
probably infra problems. I have seen than before and it sounds like a bad ccm 
env cleanup imo.
- Which rename is a breaking change in 4.0? 
{{internode_socket_send_buffer_size_in_bytes}} was changed in the code long ago 
and here we're only fixing the yml. it's like we're fixing a bug rather than 
introducing a rename right?

Otherwise lgtm.

> Fix startup issue with internode_application_timeout_in_ms
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-17132
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem 
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to