[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443845#comment-17443845
]
Ekaterina Dimitrova commented on CASSANDRA-17132:
-------------------------------------------------
{quote}[~e.dimitrova] your '4.0 patch' link point to a compare between _trunk_
and your 4.0 PR instead of 4.0 and your 4.0 PR #justfyi
{quote}
I grabbed the link on commit but I didn't open a PR, it is just the comparison
so it requires to get the 4.0 from the drop-down menu. Works perfect with
trunk, but I had to open a PR for 4.0.
{quote} - Which rename is a breaking change in 4.0?
{{internode_socket_send_buffer_size_in_bytes}} was changed in the code long ago
and here we're only fixing the yml. it's like we're fixing a bug rather than
introducing a rename right?{quote}
The thing is that we have on one side a bug(the name not changed in
cassandra.yaml), on the other one a breaking change so it is good to have the
backward compatibility with the old name for people who upgrade, similar to
what we did with metrics. I already pulled a ticket and agreed on the details
with Benedict, Alex and Aleksey.
Thank you for the review [~bereng]
> Fix startup issue with internode_application_timeout_in_ms
> ----------------------------------------------------------
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
