[ 
https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621306#comment-17621306
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17873:
-------------------------------------------------

Reran sanity check CI as there were commits yesterday and I preferred to be 
safe than sorry later. No heavy upgrade tests though.

4.0 
[#1983|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-4.0]
 * 
[testMessageDeliveryOnReconnect|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1983/workflows/e4a63e37-c890-4cdb-8d52-7ad6e26e49b6/jobs/15843/tests#failed-test-0]
 - CASSANDRA-16677
 * 
[test_resume_stopped_build|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1983/workflows/2e4cf5a1-dd1e-4a45-bfa5-cb7a7d936b27/jobs/15828/tests#failed-test-0]
 - Not related. For completeness [this 
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=test-resume-stopped-build]
 shows it fails on current 4.0. I will open a new ticket 

4.1  
[#1984|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-4.1]
 all green

trunk is green (please ignore the repeated test, the rest is green) 
[#1982|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-trunk]

To https://github.com/apache/cassandra.git

   a9df34c62a..ce1584ccc8  cassandra-4.0 -> cassandra-4.0

   f90148a344..1df5dd671e  cassandra-4.1 -> cassandra-4.1

   ac68f24512..6f709ca0ec  trunk -> trunk

 

> Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-17873
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17873
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build, Dependencies, Feature/UDF
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to 
> provide Opcodes.ASM7 but only in 1 of 3 places. 
> We need to update that for 4.0, 4.1 and trunk where we support JDK11.
> Also, I think it will be good to add one place where we update that when we 
> add new JDK support as now I see we will have to update it at 4 places at 
> least already (also for the simulator where currently it is Opcodes.ASM7 
> there, correctly added). Also, we can add a note in build.xml for people 
> updating ASM. I think many people practice updating Opcodes.ASM* with the 
> update of ASM version but in our case with update of JDK, from what I see. We 
> will need to switch to ASM9 when we add the JDK 17 support. One stop place 
> for that and adding a note for maintainers sounds like the right way to move 
> forward at least on trunk. 
> But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I 
> can tell.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to