[
https://issues.apache.org/jira/browse/CASSANDRA-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620682#comment-17620682
]
Ekaterina Dimitrova commented on CASSANDRA-17873:
-------------------------------------------------
4.0:
*
[testTruncationReleasesLogSpace|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1977/workflows/041331ac-fce0-47ac-b475-83759ac4e2c7/jobs/15701/tests#failed-test-0]
- known issue from CASSANDRA-17884
* testDropCompactStorage - CASSANDRA-17674
4.1:
* test_compression_cql_options - CASSANDRA-16861
* test_quorum_requirement - known problem from CASSANDRA-17922 _I think_ (cc
[~brandon.williams])
trunk:
* testOutboundConnectionsAreInterruptedWhenAuthFails - seems like flaky test
that has nothing to do with this patch; I ran it [500 times with latest
trunk|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1980/workflows/65ac078b-cb6a-4eb9-b8f0-b650e2886c13/jobs/15771/tests#failed-test-0]
and it fails in a few different ways:
{code:java}
junit.framework.AssertionFailedError: expected:<0> but was:<1> at
org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest.lambda$testOutboundConnectionsAreRejectedWhenAuthFails$776879b6$1(InternodeEncryptionEnforcementTest.java:113)
at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748){code}
{code:java}
junit.framework.AssertionFailedError at
org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest.lambda$testOutboundConnectionsAreInterruptedWhenAuthFails$776879b6$1(InternodeEncryptionEnforcementTest.java:164)
at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748){code}
{code:java}
junit.framework.AssertionFailedError: expected:<0> but was:<2> at
org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest.lambda$testOutboundConnectionsAreRejectedWhenAuthFails$776879b6$1(InternodeEncryptionEnforcementTest.java:113)
at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748){code}
It is significantly more flaky on JDK8. The stack traces were from JDK8.
(failed 115 times out of 500)
In JDK11 we see: (only 7 failures out of 500)
{code:java}
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in
the report does not reflect the time until the timeout. at
jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.util.Vector.forEach(Vector.java:1388) at
jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.util.Vector.forEach(Vector.java:1388) at
jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43){code}
{code:java}
junit.framework.AssertionFailedError: expected:<0> but was:<1> at
org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest.lambda$testOutboundConnectionsAreRejectedWhenAuthFails$776879b6$1(InternodeEncryptionEnforcementTest.java:113)
at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at
org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at
org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:829){code}
Now funny enough neither of those is the same timeout I see with my patch :D
So I ran 500 times the test class with the patch(rebased again as there were a
few commits from today, not affecting this patch but just to ensure we are on
par with only this commit difference) in a loop to check "the state of the
art": - [run
1981|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17873-trunk]
Similar results for trunk
* testRestartWithUUIDDisabled - consistently failed with JDK8 and also JDK11;
I do not see how it can be related to this patch; I also saw it failing in the
last two Jenkins runs so I just opened a ticket and pinged the authors;
CASSANDRA-17975
With all that in mind I'd say I commit this ticket and open one more follow up
ticket for testOutboundConnectionsAreInterruptedWhenAuthFails. WDYT?
> Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17873
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17873
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Dependencies, Feature/UDF
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to
> provide Opcodes.ASM7 but only in 1 of 3 places.
> We need to update that for 4.0, 4.1 and trunk where we support JDK11.
> Also, I think it will be good to add one place where we update that when we
> add new JDK support as now I see we will have to update it at 4 places at
> least already (also for the simulator where currently it is Opcodes.ASM7
> there, correctly added). Also, we can add a note in build.xml for people
> updating ASM. I think many people practice updating Opcodes.ASM* with the
> update of ASM version but in our case with update of JDK, from what I see. We
> will need to switch to ASM9 when we add the JDK 17 support. One stop place
> for that and adding a note for maintainers sounds like the right way to move
> forward at least on trunk.
> But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I
> can tell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
