[ 
https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627132#comment-17627132
 ] 

Stefan Miklosovic commented on CASSANDRA-16640:
-----------------------------------------------

I would rename this ticket so it adds IF NOT EXISTS to that cql statement and 
we would add all related tests to that. In other words, we are fixing IF NOT 
EXISTS and while doing so, we added related tests and we put some more on top. 
I am not sure where it should go but I would say to 4.0 (I do not know since 
when we support IF NOT EXISTS on ALTER ROLE, we need to check that). If CQL 
shell is not offering IF NOT EXISTS and CQL supports it, that is a regular bug. 
Originally, this ticket was only about adding more tests but we started to add 
more functionality as well.

What do you think? I ll rename this ticket and I will reflect what needs to be 
done in description if you can not do that yourself (because of permissions and 
similar, I do not know how you have it).

> Round out cqlsh completion test coverage
> ----------------------------------------
>
>                 Key: CASSANDRA-16640
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16640
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter, Test/unit
>            Reporter: Adam Holmberg
>            Assignee: Brad Schoening
>            Priority: Low
>             Fix For: 4.x
>
>
> There are some missing tests in cqlsh completion. Some highlighted 
> [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824].
>  There might be more needing coverage that are not enumerated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to