[
https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628068#comment-17628068
]
Brad Schoening edited comment on CASSANDRA-16640 at 11/4/22 7:29 PM:
---------------------------------------------------------------------
[~smiklosovic] so, it turns out to be a little awkward to split these back out,
as in error prone. The intent of this Jira was to improve unit test coverage
of the completions: {_}round out cqlsh completion test coverage{_}, so it seems
correct to add missing create/drop type, create/drop role, capture and patch
here. They were missing from the completions tests and part of rounding them
out. Also, adding unit test often means fixing the upstream code along side
the tests, but I've now put those completion fixes in a separate PR.
was (Author: bschoeni):
[~smiklosovic] so, it turns out to be a little awkward to split these back out,
as in error prone. The intent of this Jira was to improve unit test coverage
of the completions: {_}round out cqlsh completion test coverage{_}, so it seems
correct to add missing create/drop type, create/drop role, capture and patch
here. They were missing from the completions tests and part of rounding them
out. Also, adding unit test often means fixing the upstream code along side
the tests, but I've now put those fixes in a separate PR.
> Round out cqlsh completion test coverage
> ----------------------------------------
>
> Key: CASSANDRA-16640
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16640
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter, Test/unit
> Reporter: Adam Holmberg
> Assignee: Brad Schoening
> Priority: Low
> Fix For: 4.x
>
>
> There are some missing tests in cqlsh completion. Some highlighted
> [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824].
> There might be more needing coverage that are not enumerated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
