[
https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629371#comment-17629371
]
Stefan Miklosovic edited comment on CASSANDRA-16640 at 11/5/22 7:41 PM:
------------------------------------------------------------------------
java 11
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1534/workflows/bfc2b89c-0c41-4bc4-9566-ce69a908902f
java 8
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1534/workflows/197401c3-43f2-49fc-8389-f1ffe932c99a
I am +1 to merge it to trunk. This is the super set of CASSANDRA-18006 if I get
it right ...
[~brandon.williams] what do you think? Good to go to trunk?
We can either merge fixing what is missing in cqlsh along with tests in one pr
or we can split it. This PR fixes it all in one shot.
was (Author: smiklosovic):
java 11
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1534/workflows/bfc2b89c-0c41-4bc4-9566-ce69a908902f
java 8
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1534/workflows/197401c3-43f2-49fc-8389-f1ffe932c99a
I am +1 to merge it to trunk. This is the super set of CASSANDRA-18006 if I get
it right ...
[~brandon.williams] what do you think? Good to go to trunk?
We can either merge fixing what is missing with cqlsh along with tests in one
pr or we can split it. This PR fixes it all in one shot.
> Round out cqlsh completion test coverage
> ----------------------------------------
>
> Key: CASSANDRA-16640
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16640
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter, Test/unit
> Reporter: Adam Holmberg
> Assignee: Brad Schoening
> Priority: Low
> Fix For: 4.x
>
>
> There are some missing tests in cqlsh completion. Some highlighted
> [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824].
> There might be more needing coverage that are not enumerated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]