[ 
https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627159#comment-17627159
 ] 

Brad Schoening edited comment on CASSANDRA-16640 at 11/4/22 7:30 PM:
---------------------------------------------------------------------

[~smiklosovic] 

Yes, the missing if exists/not exists completions are probably a bug in 4.0 and 
4.1.  But it's such a minor nit, I would not suggest back porting any of them.


was (Author: bschoeni):
[~smiklosovic] that fine to split out the production rule changes.  Can you 
commit just the changes in pylib/cqlshlib/test/test_cqlsh_completion.py and 
I'll create a new Jira and PR.

Yes, the missing if exists/not exists completions are probably a bug in 4.0.

> Round out cqlsh completion test coverage
> ----------------------------------------
>
>                 Key: CASSANDRA-16640
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16640
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter, Test/unit
>            Reporter: Adam Holmberg
>            Assignee: Brad Schoening
>            Priority: Low
>             Fix For: 4.x
>
>
> There are some missing tests in cqlsh completion. Some highlighted 
> [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824].
>  There might be more needing coverage that are not enumerated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to