[ 
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629522#comment-17629522
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17950:
-------------------------------------------------

The patch LGTM but there were numerous changes committed to CircleCI config 
lately, so I suggested to help rebase and regenerate the patches. The outcome 
can be found on [this 
commit|https://github.com/ekaterinadimitrova2/cassandra/commit/0386995747368d8da71ff963c1fdabc6b96d7236]
 

I also pushed a CI run for 3.11 to verify I didn't make a mess 
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2034/workflows/f78cfc58-8135-4edf-ad5f-072ec6f57b53],
 only the separate workflow jobs for now. 

[~dchenbecker] , [~adelapena] do you mind to verify this one and if it looks 
fine I will propagate it to the other branches and also make the JDK11 version 
of it in the newer branches. Thanks in advance. 

Actually, while pushing to CI I realized in the newer versions where we have 
split CQLSH DTests from the others as we run those with both Python2 and 
Python3 - we will need probably an offheap version for those? Also, if I look 
correctly it seems we run the CQLSH tests in 4.0 in Jenkins only with one 
Python version?

I also verified the number of off heap tests run in 
[Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-3.11-dtest-offheap/lastBuild/testReport/]
 and 
[CircleCI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2034/workflows/f78cfc58-8135-4edf-ad5f-072ec6f57b53/jobs/16277/tests]
 was the same - 1077

> Enable dtest-offheap in CircleCI
> --------------------------------
>
>                 Key: CASSANDRA-17950
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Test/dtest/python
>            Reporter: Derek Chen-Becker
>            Assignee: Derek Chen-Becker
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to