[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631124#comment-17631124
]
Andres de la Peña commented on CASSANDRA-17950:
-----------------------------------------------
bq. I did it intentionally that way. My reasoning - we do not change the
current setup but we also do not want the new ones to be mandatory as we
haven't really seen them failing without the others failing. But I agree that
we need a broader agreement on what will be mandatory and what not after we
have all jobs presented, annual re-evaluation if you will
Yes, yes, I'm happy with not making them mandatory on the pre-commit workflow.
It's the buttons on the separate workflows what I think we could rearrange,
having either a single approval step for all types of cqlsh dtests, or three
separate approval steps for regular, vnodes and offheap cqlsh dtests. That's
just a small improvement and we can do it separately, maybe in that followup
ticket for homogenizing names. But we have a lot of more pressing things to do
before.
bq. So do I hear I have +1 to commit this one and move to the last ticket on
the line? Derek Chen-Becker ? Michael Semb Wever ?
+1 from me.
> Enable dtest-offheap in CircleCI
> --------------------------------
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
> Reporter: Derek Chen-Becker
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
