[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631111#comment-17631111
]
Ekaterina Dimitrova commented on CASSANDRA-17950:
-------------------------------------------------
{quote}I have tested the patches locally to see that the patches apply cleanly,
the repeated jobs are removed on the absence on tests to be repeated, etc. All
looks good to me to the extent that, as we know, it's a quite manual process. I
hope not to have missed anything.
{quote}
Thank you so much for doing that and for the quick review :)
{quote}I see that on pre-commit offheap cqlsh dtests are optional, whereas
regular and vnodes cqlsh dtests are mandatory, which is ok to me. However, it's
a bit odd that on the separate workflows there is a separate approval step for
offheap cqlsh dtests, whereas regular and vnodes cqlsh dtests are grouped
together under a single approval step. I think we should probably have either a
single approval step for all types of cqlsh dtests, or three separate approval
steps for regular, vnodes and offheap cqlsh dtests. Since that would be just a
very minor improvement we can do it in a separate ticket, and keep going with
this as it is so we get to CI parity as soon as possible.
{quote}
I did it intentionally that way. My reasoning - we do not change the current
setup but we also do not want the new ones to be mandatory as we haven't really
seen them failing without the others failing. But I agree that we need a
broader agreement on what will be mandatory and what not after we have all jobs
presented, annual re-evaluation if you will :D
So do I hear I have +1 to commit this one and move to the last ticket on the
line? [~dchenbecker] ? [~mck] ?
> Enable dtest-offheap in CircleCI
> --------------------------------
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
> Reporter: Derek Chen-Becker
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
