[
https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689667#comment-17689667
]
Michael Semb Wever edited comment on CASSANDRA-18179 at 2/16/23 12:56 PM:
--------------------------------------------------------------------------
JdkProperties was never being compiled or called. This broke the targets:
eclipse-warnings, checkstyle, and _maybe_update_idea_to_java11.
The {{keepbrief}} macro in build.xml is never called. And {{test/anttasks/}}
*does not* compile!
I don't know what to do about keepbrief, I suggest a separate ticket to
investigate it. (EDIT: I've created CASSANDRA-18267)
This patch ninja-fixes JdkProperties and fixes the above targets:
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18179_1/trunk
CI
- https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2241/
- https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/89
was (Author: michaelsembwever):
JdkProperties was never being compiled or called. This broke the targets:
eclipse-warnings, checkstyle, and _maybe_update_idea_to_java11.
The {{keepbrief}} macro in build.xml is never called. And {{test/anttasks/}}
*does not* compile!
I don't know what to do about keepbrief, I suggest a separate ticket to
investigate it.
This patch ninja-fixes JdkProperties and fixes the above targets:
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18179_1/trunk
CI
- https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2241/
- https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/89
> Update build.xml for experimental JDK17 use
> -------------------------------------------
>
> Key: CASSANDRA-18179
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18179
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 4.2
>
>
> To support JDK17 we need to make changes to build.xml and our scripts. There
> is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17
> but it will need a change considering CASSANDRA-18133
> CC [~mck]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]