[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708509#comment-17708509
]
Ekaterina Dimitrova edited comment on CASSANDRA-18262 at 4/4/23 5:30 PM:
-------------------------------------------------------------------------
Thank you for the quick response!
Yes, you can enable it to work with any of the JDKs, but when you run ant jar
checkstyle -is currently- *was* triggered always only with JDK8. (before the
last patch here)
So yes, CI will run it only with JDK8, the idea of this ticket was to switch
checkstyle and eclipse-warnings (that one was left to another ticket due to
complications) to run in CI with JDK11 in preparation to drop JDK8.
Looking back, I think I see where the confusion came from. The initial patch
[~brandon.williams] has posted
[here|https://github.com/driftx/cassandra/commit/8b2c533beb9d3205052c2a7bb4df4c44a580bc61]
was enabling the checkstyle run with all JDK versions in CI and he changed
that to only 11 pre-commit as per our agreement.
The switch happened
[here|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2]
but it got reverted
[here|https://github.com/apache/cassandra/commit/7ad746cc839199ac9b8d7ba9a6f2b2f980ea3461]
was (Author: e.dimitrova):
Thank you for the quick response!
Yes, you can enable it to work with any of the JDKs, but when you run ant jar
checkstyle -is currently- *was* triggered always only with JDK8. (pre the last
patch here)
So yes, CI will run it only with JDK8, the idea of this ticket was to switch
checkstyle and eclipse-warnings (that one was left to another ticket due to
complications) to run in CI with JDK11 in preparation to drop JDK8.
Looking back, I think I see where the confusion came from. The initial patch
[~brandon.williams] has posted
[here|https://github.com/driftx/cassandra/commit/8b2c533beb9d3205052c2a7bb4df4c44a580bc61]
was enabling the checkstyle run with all JDK versions in CI and he changed
that to only 11 pre-commit as per our agreement.
The switch happened
[here|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2]
but it got reverted
[here|https://github.com/apache/cassandra/commit/7ad746cc839199ac9b8d7ba9a6f2b2f980ea3461]
> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
