[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708853#comment-17708853
]
Stefan Miklosovic edited comment on CASSANDRA-18262 at 4/5/23 12:37 PM:
------------------------------------------------------------------------
_I think we have too much Patch Available backlog to encourage people to
develop and submit patches on other versions, to find out things need to be
reworked only with CI and reviews._
This might be resolved just by enabling checkstyle while they are on Java 11? I
do not get why having too many patches in backlog is necessarily bad thing.
_Honestly, considering the build goes from 1 minute to 3 from what I see in the
comments, I fear most people probably even use the option to skip checkstyle
many times locally_
But that is entirely on them. My perception is different. They would love to
offer valid code before asking somebody to review, definitely.
_By the way I had similar discussion with Mick around adding intellij idea
target for JDK17 and I was told we should not encourage development against
other versions._
That is reasonable because we are not supporting Java 17 officially yet. If we
officially support Java 11 (right?), why would we restrict them to develop on
it with one caveat that it has to compile to Java 8. But having checkstyle
triggered on 11 seems like totally innocent thing.
was (Author: smiklosovic):
_I think we have too much Patch Available backlog to encourage people to
develop and submit patches on other versions, to find out things need to be
reworked only with CI and reviews._
This might be resolved just by enabling checkstyle while they are on Java 11? I
do not get why having too many patches in backlog is necessarily bad thing.
_Honestly, considering the build goes from 1 minute to 3 from what I see in the
comments, I fear most people probably even use the option to skip checkstyle
many times locally_
But that is entirely on them. My perception is different. They would love to
offer valid code before asking somebody to review, definitely.
> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
