[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708835#comment-17708835
]
Stefan Miklosovic edited comment on CASSANDRA-18262 at 4/5/23 12:04 PM:
------------------------------------------------------------------------
one reason could be that people are developing locally against Java 11 already.
Then they ask a committer to build a CI for them and then we realize that it
does not work. Like here
https://github.com/apache/cassandra/pull/2253/commits/db57b0c5e38b232b59bc72ddbb2b1a0933b87459
Talking to him privately, he was developing on Java 11 so checkstyle was not
triggered.
The fact that _we_ are developing on 8 does not mean that everybody does. I do
not think that restricting / forcing them to be on Java 8 is necessary. Another
thing is if they are using APIs present in Java 11 only but I faced that maybe
once.
was (Author: smiklosovic):
one reason could be that people are developing locally against Java 11 already.
Then they ask a committer to build a CI for them and then we realize that it
does not work. Like here
https://github.com/apache/cassandra/pull/2253/commits/db57b0c5e38b232b59bc72ddbb2b1a0933b87459
Talking to him privately, he was developing on Java 11 so checkstyle was not
triggered.
The fact that _we_ are developing on 8 does not mean that everybody does. I do
not think that restricting / forcing them to be on Java 8 is necessary. Another
thing is if they are using APIs present in Java 11 only but I faced that fact
maybe once.
> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
