[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708524#comment-17708524
]
Maxim Muzafarov commented on CASSANDRA-18262:
---------------------------------------------
I have checked the commits you mentioned and it seems it's everything looks
correct
[first|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2]
>
[second|https://github.com/apache/cassandra/commit/7ad746cc839199ac9b8d7ba9a6f2b2f980ea3461]
> [the last
one|https://github.com/apache/cassandra/commit/4e3447ae1727a0d01c9d81792acbdeeef94d86d2]
I could be wrong, we should be able to run checkstyle locally regardless of the
jdk version used, right? So, I'm able to build the project locally with all the
jdk versions we support, and the sources are also checked with an appropriate
checkstyle (the version of the library is automatically selected, leaving the
configuration the same as it is backwards compatible). If we are going to
remove j8, so no changes are required in the checkstyle part to be taken.
What is the reason for running checkstyle only for j11? I can't catch the idea
of it.
> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
