[
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708590#comment-17708590
]
Maxim Muzafarov commented on CASSANDRA-18262:
---------------------------------------------
As I understand your concerns, you are talking about removing the
{_}"if="java.version.8"{_}, rather than replacing it with
{_}"if="java.version.11"{_}, right?
The problem with the code checking tool is that it only does its checks for j8
(as it was before the patch), we want to switch to j11 and say "From now on,
the minimum version required for Cassandra is j11" but the checkstyle was
skipped for j11. If we will do the same kind of switch to j17, we will face the
same, so the problem itself doesn't go away in our case.
Instead of tying the code-checking tool to a specific version, we should make
it work for every jdk we support. This has its advantages: you can run
checkstyle locally and check the sources without switching jdks, we won't face
this problem in the future, and the patch doesn't prevent us from removing j8.
In summary, removing the _"if="java.version.8"_ condition from the ant task
seems to be the right thing to do.
So, the checkstyle:
|| ||before the patch||after the patch||
|j8|checks perform|checks perform|
|j11|skipped|checks perform|
|j17|skipped|checks perform|
If we drop j8 here, everything will still work.
Am I missing something?
> Switch checkstyle running only with JDK8 to be run with JDK11
> -------------------------------------------------------------
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?)
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
