[ 
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744185#comment-17744185
 ] 

Jacek Lewandowski commented on CASSANDRA-17992:
-----------------------------------------------

I think we may use more radical approach:

{code}
  <target name="dtest-jar" depends="build-test, build" description="Create 
dtest-compatible jar, including all dependencies">
      <delete dir="${build.dir}/dtest/**" quiet="true"/>

      <copy todir="${build.dir}/dtest" quiet="true">
          <fileset dir="${build.classes.main}"/>
          <fileset dir="${test.classes}"/>
          <fileset dir="${test.conf}" />
      </copy>
      <unzip dest="${build.dir}/dtest">
          <fileset dir="${test.lib}/jars" 
includes="jimfs-1.1.jar,dtest-api-*.jar,asm-*.jar,javassist-*.jar,reflections-*.jar,semver4j-*.jar"/>
      </unzip>
      <unzip dest="${build.dir}/dtest">
          <fileset dir="${build.dir.lib}/jars" includes="*.jar"/>
      </unzip>

      <jar jarfile="${build.dir}/dtest-${base.version}.jar" 
duplicate="preserve">
          <fileset dir="${build.dir}/dtest">
              <exclude name="META-INF/*.SF"/>
              <exclude name="META-INF/*.DSA"/>
              <exclude name="META-INF/*.RSA"/>
          </fileset>
      </jar>

      <delete dir="${build.dir}/dtest"/>
  </target>
{code}

which should be probably applied to all branches


> Upgrade Netty on 5.0
> --------------------
>
>                 Key: CASSANDRA-17992
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Jacek Lewandowski
>            Priority: Low
>             Fix For: 5.x
>
>
> I haven't been able to identify from the Netty docs which was the lowest 
> version where JDK17 was added but we are about 40 versions behind in netty 4 
> so I suspect we better update. 
> -We need to consider there was an issue with class cast exceptions when 
> building with JDK17 with newer versions of netty (the newest available in 
> March 2022). For the record, we didn't see those when running CI on JDK8 and 
> JDK11. We also need to carefully revise the changes between the netty 
> versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in 
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF 
> Slack thread. 
> CC [~benedict] , [~aleksey] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to