[
https://issues.apache.org/jira/browse/CASSANDRA-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745268#comment-17745268
]
Maulin Vasavada commented on CASSANDRA-18428:
---------------------------------------------
Hi [~mmuzaf] Thanks for the review. Will check on the suggestions soon. One
traditional issue I have faced with the changes is the 'style issue'. Currently
when I run the `ant checkstyle` it successfully completes it without errors, so
not sure how can I catch those errors before I can raise a PR.
In the past I had similar challenge and something with JDK11 was found to be an
issue skipping the actual style check. Now I am not sure what could be the
issue.
{noformat}
checkstyle:
[checkstyle] Running Checkstyle 10.8.1 on 2201 files
BUILD SUCCESSFUL
Total time: 33 seconds{noformat}
Let me see if I see anything different with a fresh local build.
> Implement/override equals and hashCode methods in the ServerEncryptionOptions
> class
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-18428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18428
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Maulin Vasavada
> Assignee: Maulin Vasavada
> Priority: Normal
> Labels: lhf
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We have {{equals and hashCode}} methods in
> [EncryptionOptions|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L551]
> object but not (overridden/extended) in
> [ServerEncryptionOptions.|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/EncryptionOptions.java#L600]
> Code is using the EncryptionOptions as the key in the
> [ConcurrentHashMap|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/SSLFactory.java#L84]
> in the SSLFactory.java. Hence technically we must have a equals/hashCode
> override in the ServerEncryptionOptions to account for fields that matter
> additionally (e.g. outbound_keystore/password).
> We discussed this over the [cassandra-dev slack
> channel|https://the-asf.slack.com/archives/CK23JSY2K/p1680118849081399] and
> it seems agreeable to make this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
