[
https://issues.apache.org/jira/browse/CASSANDRA-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786803#comment-17786803
]
Andres de la Peña commented on CASSANDRA-18948:
-----------------------------------------------
Thanks for the fixes. They mostly look good to me, I have left a couple of nits
on the PR.
The CI runs I posted included 2K runs for different utest configs. If we run
them again
([j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3310/workflows/4bc06ad4-54b2-443b-b4b3-4353ae9210a7],
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3310/workflows/05a02712-758d-415f-9b41-2766eb8950b2]),
the only failure that is repeatedly hit is the timeout in
{{{}testCompletedFlag{}}}. I don't know why that particular test is affected.
It isn't an especially slow test. Maybe we can commit these fixes and
investigate that timeout separately?
As for branches, I think we should apply the fix since 4.0. If
{{CommitLogSegment#cdcState}} needs to be {{volatile}} then this might be a
product defect. We should also run pre-commit tests to see if that change out
of the affected tests breaks something else (I doubt it).
> Test failure:
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testReplayLogic-compression.jdk17.arch=x86_64.python2.7
>
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18948
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18948
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.0-rc
>
>
> Seen here:
> https://ci-cassandra.apache.org/job/Cassandra-5.0/71/testReport/org.apache.cassandra.db.commitlog/CommitLogSegmentManagerCDCTest/testReplayLogic_compression_jdk17_arch_x86_64_python2_7/
> h3.
> {code:java}
> Error Message
> Missing old CDCIndexData in new set after replay:
> CommitLog-7-1697673230997_cdc.idx,1747785 List of CDCIndexData in new set of
> indexes after replay: CommitLog-7-1697673230996_cdc.idx,3510561
> CommitLog-7-1697673230998_cdc.idx,3509214
> Stacktrace
> junit.framework.AssertionFailedError: Missing old CDCIndexData in new set
> after replay: CommitLog-7-1697673230997_cdc.idx,1747785 List of CDCIndexData
> in new set of indexes after replay: CommitLog-7-1697673230996_cdc.idx,3510561
> CommitLog-7-1697673230998_cdc.idx,3509214 at
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testReplayLogic(CommitLogSegmentManagerCDCTest.java:319)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
