jberragan commented on code in PR #88:
URL:
https://github.com/apache/cassandra-analytics/pull/88#discussion_r1793701592
##########
cassandra-bridge/build.gradle:
##########
@@ -40,14 +40,32 @@ publishing {
dependencies {
api(project(':cassandra-analytics-common'))
- api(project(':cassandra-analytics-spark-converter'))
- compileOnly(group: "${sparkGroupId}", name:
"spark-core_${scalaMajorVersion}", version:
"${project.rootProject.sparkVersion}")
- compileOnly(group: "${sparkGroupId}", name:
"spark-sql_${scalaMajorVersion}", version:
"${project.rootProject.sparkVersion}")
+ implementation "org.slf4j:slf4j-api:${slf4jApiVersion}"
+ compileOnly "com.esotericsoftware:kryo-shaded:${kryoVersion}"
+ compileOnly "com.google.guava:guava:${guavaVersion}"
+ compileOnly
"com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}"
+ compileOnly "com.fasterxml.jackson.core:jackson-core:${jacksonVersion}"
+ compileOnly "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}"
+
+ testImplementation(project(path: ":cassandra-analytics-spark-converter"))
+ testImplementation(group: "${sparkGroupId}", name:
"spark-core_${scalaMajorVersion}", version:
"${project.rootProject.sparkVersion}")
+ testImplementation(group: "${sparkGroupId}", name:
"spark-sql_${scalaMajorVersion}", version:
"${project.rootProject.sparkVersion}")
testImplementation(group: 'com.fasterxml.jackson.core', name:
'jackson-databind', version: "${jacksonVersion}")
testImplementation(group: 'com.google.guava', name: 'guava', version:
'31.1-jre')
testImplementation(group: 'org.slf4j', name: 'slf4j-simple', version:
'1.7.26')
testImplementation("org.junit.jupiter:junit-jupiter-api:${project.junitVersion}")
testImplementation("org.junit.jupiter:junit-jupiter-params:${project.junitVersion}")
testImplementation("org.junit.jupiter:junit-jupiter-engine:${project.junitVersion}")
}
+
+configurations {
+ testArtifacts
+}
+task testJar(type: Jar) {
+ archiveBaseName = "${project.name}-bridge-test"
+ from sourceSets.test.output
+}
+artifacts {
+ testArtifacts testJar
+}
Review Comment:
It appears `java-test-fixtures` does not support JDK8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
