yifan-c commented on code in PR #88:
URL:
https://github.com/apache/cassandra-analytics/pull/88#discussion_r1793901978
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/bridge/CassandraBridgeFactory.java:
##########
@@ -130,14 +153,20 @@ private static String typesResourceName(@NotNull String
label)
return jarResourceName(label, "types");
}
+ @NotNull
+ private static String sparkSqlResourceName(@NotNull String label)
+ {
+ return jarResourceName(label, "sparksql");
+ }
+
private static String jarResourceName(String... parts)
{
return "/bridges/" + String.join("-", parts) + ".jar";
}
@NotNull
@SuppressWarnings("unchecked")
- private static CassandraBridge create(@NotNull String label)
+ private static Pair<CassandraBridge, SparkSqlTypeConverter>
create(@NotNull String label)
Review Comment:
yeah. I find a proper data class is more readable and maintainable than
`Pair` in the long run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
