[
https://issues.apache.org/jira/browse/CASSANDRA-20038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894333#comment-17894333
]
Brandon Williams commented on CASSANDRA-20038:
----------------------------------------------
LGTM, +1 if CI looks good. There is no performance difference for checkstyle
with this patch.
> Investigate how to ban usages of "var" in production code.
> ----------------------------------------------------------
>
> Key: CASSANDRA-20038
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20038
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In this thread (1) we reached the consensus of banning usages of "var" in the
> production code but allowing it in tests. We should investigate how to handle
> this robustly, e.g. by a checkstyle rule. The investigation how to do this
> should be conducted.
> Upon delivery, that probably means that the existing usages of "var" in the
> production code will need to be fixed and converted to have it all on types
> again because such rule would fail the compilation of the production code
> otherwise.
> (1) https://lists.apache.org/thread/jfgj8lh1llp9zrodmfqyq22kvtlodyk6
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]