[
https://issues.apache.org/jira/browse/CASSANDRA-20038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894601#comment-17894601
]
Stefan Miklosovic commented on CASSANDRA-20038:
-----------------------------------------------
[CASSANDRA-20038|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20038]
{noformat}
java17_pre-commit_tests
✓ j17_build 5m 8s
✓ j17_cqlsh_dtests_py311 7m 1s
✓ j17_cqlsh_dtests_py311_vnode 7m 31s
✓ j17_cqlsh_dtests_py38 7m 11s
✓ j17_cqlsh_dtests_py38_vnode 7m 12s
✓ j17_cqlshlib_cython_tests 12m 44s
✓ j17_cqlshlib_tests 7m 20s
✓ j17_dtests 35m 56s
✓ j17_dtests_latest 38m 18s
✓ j17_dtests_vnode 38m 13s
✓ j17_jvm_dtests 25m 47s
✓ j17_unit_tests 15m 4s
✓ j17_utests_latest 14m 48s
✕ j17_jvm_dtests_latest_vnode 24m 28s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
✕ j17_utests_oa 15m 57s
org.apache.cassandra.db.commitlog.CommitlogShutdownTest
testShutdownWithPendingTasks
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4901/workflows/2257dabe-88d5-44a9-a0f4-5e8054bf30a7]
> Investigate how to ban usages of "var" in production code.
> ----------------------------------------------------------
>
> Key: CASSANDRA-20038
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20038
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In this thread (1) we reached the consensus of banning usages of "var" in the
> production code but allowing it in tests. We should investigate how to handle
> this robustly, e.g. by a checkstyle rule. The investigation how to do this
> should be conducted.
> Upon delivery, that probably means that the existing usages of "var" in the
> production code will need to be fixed and converted to have it all on types
> again because such rule would fail the compilation of the production code
> otherwise.
> (1) https://lists.apache.org/thread/jfgj8lh1llp9zrodmfqyq22kvtlodyk6
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
