[ 
https://issues.apache.org/jira/browse/CASSANDRA-20038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894600#comment-17894600
 ] 

Stefan Miklosovic commented on CASSANDRA-20038:
-----------------------------------------------

[CASSANDRA-20038-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20038-5.0]
{noformat}
java17_pre-commit_tests                         
  ✓ j17_build                                        4m 21s
  ✓ j17_cqlsh_dtests_py311                           6m 16s
  ✓ j17_cqlsh_dtests_py311_vnode                     6m 33s
  ✓ j17_cqlsh_dtests_py38                            6m 16s
  ✓ j17_cqlsh_dtests_py38_vnode                      6m 20s
  ✓ j17_cqlshlib_cython_tests                        7m 50s
  ✓ j17_cqlshlib_tests                               7m 14s
  ✓ j17_dtests                                      35m 18s
  ✓ j17_dtests_latest                               35m 27s
  ✓ j17_dtests_vnode                                35m 43s
  ✓ j17_jvm_dtests                                  22m 19s
  ✓ j17_jvm_dtests_latest_vnode                     19m 43s
  ✓ j17_unit_tests                                  15m 34s
  ✓ j17_utests_latest                               15m 47s
  ✓ j17_utests_oa                                   17m 30s
java11_pre-commit_tests                         
  ✓ j11_build                                        8m 31s
  ✓ j11_cqlsh_dtests_py311                           8m 28s
  ✓ j11_cqlsh_dtests_py311_vnode                     8m 46s
  ✓ j11_cqlsh_dtests_py38                            9m 56s
  ✓ j11_cqlsh_dtests_py38_vnode                      8m 47s
  ✓ j11_cqlshlib_cython_tests                       12m 15s
  ✓ j11_cqlshlib_tests                               6m 49s
  ✓ j11_dtests                                      35m 15s
  ✓ j11_dtests_vnode                                37m 47s
  ✓ j11_jvm_dtests                                  22m 37s
  ✓ j11_jvm_dtests_latest_vnode                     18m 35s
  ✓ j11_simulator_dtests                             2m 36s
  ✓ j11_unit_tests                                   15m 5s
  ✓ j11_utests_latest                               17m 16s
  ✓ j11_utests_oa                                   18m 39s
  ✓ j11_utests_system_keyspace_directory            20m 25s
  ✓ j17_cqlsh_dtests_py311                           6m 15s
  ✓ j17_cqlsh_dtests_py311_vnode                     6m 36s
  ✓ j17_cqlsh_dtests_py38                            6m 15s
  ✓ j17_cqlsh_dtests_py38_vnode                      6m 33s
  ✓ j17_cqlshlib_cython_tests                         8m 1s
  ✓ j17_cqlshlib_tests                               6m 37s
  ✓ j17_dtests                                      36m 25s
  ✓ j17_jvm_dtests                                  22m 52s
  ✓ j17_jvm_dtests_latest_vnode                     18m 26s
  ✓ j17_unit_tests                                  18m 51s
  ✓ j17_utests_latest                               18m 19s
  ✓ j17_utests_oa                                   16m 38s
  ✕ j11_dtests_latest                               38m 42s
      bootstrap_test.TestBootstrap test_decommissioned_wiped_node_can_join
  ✕ j17_dtests_latest                               33m 52s
      bootstrap_test.TestBootstrap test_killed_wiped_node_cannot_join
  ✕ j17_dtests_vnode                                33m 41s
      bootstrap_test.TestBootstrap test_read_from_bootstrapped_node
{noformat}

[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4903/workflows/c8c2dd7f-965c-417a-b688-825d88a0d001]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4903/workflows/4db83491-6024-4189-b840-2b1e38cdb624]


> Investigate how to ban usages of "var" in production code.
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-20038
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20038
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 5.0.x, 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In this thread (1) we reached the consensus of banning usages of "var" in the 
> production code but allowing it in tests. We should investigate how to handle 
> this robustly, e.g. by a checkstyle rule. The investigation how to do this 
> should be conducted.
> Upon delivery, that probably means that the existing usages of "var" in the 
> production code will need to be fixed and converted to have it all on types 
> again because such rule would fail the compilation of the production code 
> otherwise.
> (1) https://lists.apache.org/thread/jfgj8lh1llp9zrodmfqyq22kvtlodyk6



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to