yifan-c commented on code in PR #92:
URL:
https://github.com/apache/cassandra-analytics/pull/92#discussion_r1844256615
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriteValidator.java:
##########
@@ -110,19 +112,24 @@ public static void updateFailureHandler(CommitResult
commitResult,
});
}
- private static void logFailedRanges(Logger logger, String phase,
-
List<ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange>
failedRanges)
+ // aggregate the stream errors in order to provide a better insight on
failure
+ private static String
aggregateErrors(List<ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange>
failedRanges)
{
+ StringBuilder sb = new StringBuilder();
for
(ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange
failedRange : failedRanges)
{
- failedRange.failuresPerInstance.forEachInstance((instance, errors)
-> {
- logger.error("Failed in phase {} for {} on {}. Failure: {}",
Review Comment:
The logging is moved to `validateClOrFail`. However, I should probably not
truncate the message here. Making an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
