frankgh commented on code in PR #92:
URL:
https://github.com/apache/cassandra-analytics/pull/92#discussion_r1843071242
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriteValidator.java:
##########
@@ -110,19 +112,24 @@ public static void updateFailureHandler(CommitResult
commitResult,
});
}
- private static void logFailedRanges(Logger logger, String phase,
-
List<ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange>
failedRanges)
+ // aggregate the stream errors in order to provide a better insight on
failure
+ private static String
aggregateErrors(List<ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange>
failedRanges)
{
+ StringBuilder sb = new StringBuilder();
for
(ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange
failedRange : failedRanges)
{
- failedRange.failuresPerInstance.forEachInstance((instance, errors)
-> {
- logger.error("Failed in phase {} for {} on {}. Failure: {}",
- phase,
- failedRange.range,
- instance.toString(),
- errors);
- });
+ for (Map.Entry<RingInstance, Collection<String>> entry :
failedRange.failuresPerInstance.entrySet())
+ {
+ sb.append("Instance: ").append(entry.getKey()).append(" All
failures: ").append(entry.getValue());
Review Comment:
should we add line breaks?
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriteValidator.java:
##########
@@ -110,19 +112,27 @@ public static void updateFailureHandler(CommitResult
commitResult,
});
}
- private static void logFailedRanges(Logger logger, String phase,
-
List<ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange>
failedRanges)
+ // aggregate the stream errors in order to provide a better insight on
failure
+ private static String logEachErrorAndAggregate(Logger logger,
+ String phase,
+
List<ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange>
failedRanges)
{
+ StringBuilder sb = new StringBuilder();
for
(ReplicaAwareFailureHandler<RingInstance>.ConsistencyFailurePerRange
failedRange : failedRanges)
{
- failedRange.failuresPerInstance.forEachInstance((instance, errors)
-> {
- logger.error("Failed in phase {} for {} on {}. Failure: {}",
- phase,
- failedRange.range,
- instance.toString(),
- errors);
- });
+ for (Map.Entry<RingInstance, Collection<String>> entry :
failedRange.failuresPerInstance.entrySet())
+ {
+ logger.error("Failed in phase {} for {} on {}. Failure: {}",
phase, failedRange.range, entry.getKey(), entry.getValue());
+ if (sb.length() > ERROR_MESSAGE_MAX_LENGTH)
Review Comment:
should be >=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
