yifan-c commented on code in PR #92:
URL:
https://github.com/apache/cassandra-analytics/pull/92#discussion_r1844268469
##########
scripts/build-dtest-jars.sh:
##########
@@ -52,7 +52,7 @@ else
if [[ "$CLEAN" == "true" ]]; then
echo "Clean up $DTEST_JAR_DIR"
rm -rf "$DTEST_JAR_DIR/cassandra-build"
- rm "$DTEST_JAR_DIR/dtest*.jar"
+ rm -rf "$DTEST_JAR_DIR/dtest*.jar"
Review Comment:
Because it failed to remove files. I got this error.
```
+ rm '.../cassandra-analytics/dependencies/dtest*.jar'
rm: .../cassandra-analytics/dependencies/dtest*.jar: No such file or
directory
```
However, adding `-rf` is not the correct fix. It just hides the error.
The correct `rm` command is `rm "$DTEST_JAR_DIR"/dtest*.jar`
Thanks for bringing it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
