yifan-c commented on code in PR #131: URL: https://github.com/apache/cassandra-analytics/pull/131#discussion_r2277362903
########## cassandra-five-zero-bridge/src/test/java/org/apache/cassandra/utils/ReflectionUtils.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cassandra.utils; + +import java.lang.reflect.Field; +import java.lang.reflect.Method; + +/** + * Reflection utilities used for testing + */ +public final class ReflectionUtils Review Comment: This class seems to be a good candidate to move out of the bridge subproject. Maybe to `common`? There could be other such classes that are suitable for relocation. ########## cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java: ########## @@ -260,7 +260,10 @@ protected void tearDown() throws Exception */ protected ClusterBuilderConfiguration testClusterConfiguration() { - return new ClusterBuilderConfiguration(); + ClusterBuilderConfiguration conf = new ClusterBuilderConfiguration(); + // TODO: Shall we read requested compatibility from sidecar? Review Comment: I think it is a good idea. Sidecar can actually do a better job. Instead of returning compatibility mode, sidecar can return the desired sstable version it can accept, basically [CASSANALYTICS-24](https://issues.apache.org/jira/browse/CASSANALYTICS-24) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
