lukasz-antoniak commented on code in PR #131:
URL:
https://github.com/apache/cassandra-analytics/pull/131#discussion_r2298230166
##########
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/expansion/JoiningMultiDCTest.java:
##########
@@ -141,7 +141,7 @@ public static boolean bootstrap(Collection<?> tokens,
boolean result = orig.call();
// trigger bootstrap start and wait until bootstrap is ready from
test
transitioningStateStart.countDown();
-
TestUninterruptibles.awaitUninterruptiblyOrThrow(transitioningStateEnd, 2,
TimeUnit.MINUTES);
+
TestUninterruptibles.awaitUninterruptiblyOrThrow(transitioningStateEnd, 5,
TimeUnit.MINUTES);
Review Comment:
Shall we create an environment variable to fine-tune timeout? Locally could
be smaller, but on CI larger.
##########
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/expansion/JoiningMultiDCTest.java:
##########
@@ -141,7 +141,7 @@ public static boolean bootstrap(Collection<?> tokens,
boolean result = orig.call();
// trigger bootstrap start and wait until bootstrap is ready from
test
transitioningStateStart.countDown();
-
TestUninterruptibles.awaitUninterruptiblyOrThrow(transitioningStateEnd, 2,
TimeUnit.MINUTES);
+
TestUninterruptibles.awaitUninterruptiblyOrThrow(transitioningStateEnd, 5,
TimeUnit.MINUTES);
Review Comment:
Shall we create an environment variable to fine-tune timeout? Locally could
be smaller, but on CI larger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
