lukasz-antoniak commented on code in PR #131:
URL:
https://github.com/apache/cassandra-analytics/pull/131#discussion_r2273168875
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/TestUtils.java:
##########
@@ -278,6 +278,14 @@ public static Gen<CassandraVersion> versions()
return arbitrary().pick(CassandraVersion.implementedVersions());
}
+ public static Gen<CassandraVersion> versions(CassandraBridge bridge)
+ {
+ List<CassandraVersion> versions =
Arrays.stream(CassandraVersion.implementedVersions())
+ .filter(v ->
bridge.getVersion().equals(v))
+ .collect(Collectors.toList());
+ return arbitrary().pick(versions);
+ }
Review Comment:
When I was implementing it, I though we could have multiple testable
versions with same bridge. But C* version is major + minor (e.g. 40, 41, 50),
so indeed this does not make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
