skoppu22 commented on code in PR #211:
URL:
https://github.com/apache/cassandra-analytics/pull/211#discussion_r3348169486
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SortedSSTableWriter.java:
##########
@@ -297,6 +305,18 @@ public synchronized void close(BulkWriterContext
writerContext) throws IOExcepti
validateSSTables(writerContext);
}
+ protected void rebuildFilterComponents(@NotNull BulkWriterContext
writerContext,
+ @NotNull
DirectoryStream.Filter<Path> filter) throws IOException
+ {
+ LocalDataLayer layer = buildLocalDataLayer(writerContext, getOutDir(),
null);
+ for (Path dataFile : getDataFileStream(filter))
Review Comment:
Should we move getDataFileStream inside try-with-resources to autoclose?
Same call above at line 292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
