skoppu22 commented on code in PR #211:
URL:
https://github.com/apache/cassandra-analytics/pull/211#discussion_r3334550055
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SortedSSTableWriter.java:
##########
@@ -227,6 +229,15 @@ public synchronized Map<Path, Digest>
prepareSStablesToSend(@NotNull BulkWriterC
};
Set<Path> dataFilePaths = new HashSet<>();
Map<Path, Digest> fileDigests = new HashMap<>();
+ // FIXME: CQLSSTableWriter may produce incomplete Filter.db file,
rebuilding it manually (see CASSANALYTICS-167).
Review Comment:
If I understand correctly, we are rebuilding complete bloom filter, instead
of fixing the actual cause (the cause of empty bloom filter), because the later
requires changes in both C* 4.0 and 5.0 and new release/backporting etc in
Cassandra, am I right? Can we create a Jira to fix this in upcoming C* versions
so we can avoid completely rebuilding for upcoming C* versions, and add
corresponding Jira here in comments, so we don't forget by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
