skoppu22 commented on code in PR #211:
URL:
https://github.com/apache/cassandra-analytics/pull/211#discussion_r3334723017
##########
cassandra-five-zero-bridge/src/main/java/org/apache/cassandra/bridge/CassandraBridgeImplementation.java:
##########
@@ -348,6 +352,64 @@ public org.apache.cassandra.bridge.BloomFilter
openBloomFilter(Partitioner parti
};
}
+ @Override
+ public void rebuildBloomFilter(@NotNull Partitioner partitioner,
+ @NotNull CqlTable cqltable,
+ @NotNull SSTable ssTable,
+ @NotNull Path directory) throws IOException
+ {
+ String keyspace = cqltable.keyspace();
+ String table = cqltable.table();
+ IPartitioner iPartitioner = getPartitioner(partitioner);
+ SchemaBuilder schemaBuilder = new SchemaBuilder(cqltable, partitioner);
+ TableMetadata tableMetadata = schemaBuilder.tableMetaData();
+
+ if (tableMetadata.params.bloomFilterFpChance == 1.0)
Review Comment:
I guess here == comparison on doubles is safe as 1.0 doesn't involve rounding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
