lukasz-antoniak commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3447405059
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/cloudstorage/coordinated/CassandraClusterInfoGroup.java:
##########
@@ -84,35 +85,37 @@ public class CassandraClusterInfoGroup implements
ClusterInfo, MultiClusterSuppo
private volatile TokenRangeMapping<RingInstance>
consolidatedTokenRangeMapping;
// Pre-computed values from BroadcastableClusterInfoGroup (only set when
reconstructed on executors)
private Partitioner cachedPartitioner;
- private String cachedLowestCassandraVersion;
/**
* Creates {@link CassandraClusterInfoGroup} with the list of {@link
ClusterInfo} from {@link BulkSparkConf} and validation
* The validation ensures non-empty list of {@link ClusterInfo}, where all
objects have non-empty and unique clusterId
* @param conf bulk write conf
+ * @param bridgeVersion bridge version (nullable for preliminary
construction)
* @return new {@link CassandraClusterInfoGroup} instance
*/
- public static CassandraClusterInfoGroup fromBulkSparkConf(BulkSparkConf
conf)
+ public static CassandraClusterInfoGroup fromBulkSparkConf(BulkSparkConf
conf, CassandraVersion bridgeVersion)
Review Comment:
NIT, `bridgeVersion` seems always passed `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
