lukasz-antoniak commented on code in PR #169:
URL:
https://github.com/apache/cassandra-analytics/pull/169#discussion_r3447984045
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -272,7 +278,11 @@ private int initBulkReader(@NotNull ClientConfig options)
throws ExecutionExcept
NodeSettings nodeSettings = sidecar.nodeSettings().get();
String cassandraVersion =
getEffectiveCassandraVersionForRead(clusterConfig, nodeSettings);
Partitioner partitioner = Partitioner.from(nodeSettings.partitioner());
- bridge = CassandraBridgeFactory.get(cassandraVersion);
+
+ // Initialize SSTable versions and bridge version
+ CassandraVersion bridgeVersion =
initializeSSTableVersionsAndBridgeVersion(cassandraVersion);
+ bridge = CassandraBridgeFactory.get(bridgeVersion);
Review Comment:
Should we add here the log analogical to write-side, e.g. `"Selected bridge
version: {}, SSTable versions: {}`?
In the `determineBridgeVersionForRead` we have below log which is not
present in `determineBridgeVersionForWrite`.
```
LOGGER.debug("Determined bridge version {} for read based on SSTable
versions on cluster: {}", bridgeVersion.versionName(),
sstableVersionsOnCluster);
```
I would suggest to make both logs about determined sstable version
"symmetric".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
