michaelsembwever commented on code in PR #236:
URL:
https://github.com/apache/cassandra-analytics/pull/236#discussion_r3992598438
##########
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/ResiliencyTestBase.java:
##########
@@ -59,6 +61,33 @@ public abstract class ResiliencyTestBase extends
SharedClusterSparkIntegrationTe
{
public static final String QUERY_ALL_ROWS = "SELECT * FROM %s";
+ /**
+ * Skips the test class when the version under test declares none of the
internals that the ByteBuddy hooks of a
+ * topology-change test intercept: {@code
StorageService.bootstrap(Collection, long)},
+ * {@code StorageService.unbootstrap()} and {@code
RangeRelocator.stream()}. CEP-21 Transactional Cluster Metadata
+ * removed all three in Cassandra 6.0, in favour of {@code
org.apache.cassandra.tcm.sequences}. A hook that fails
+ * to install is silent, so the test would instead wait on a latch that
never counts down.
+ *
+ * <p>Call this from {@link #beforeClusterProvisioning()}, which runs
before the cluster starts.</p>
+ */
+ protected void assumeTopologyChangeHooksSupported()
Review Comment:
yes, see CASSANALYTICS-112 (i'll offer a separate PR for it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
