michaelsembwever commented on code in PR #236: URL: https://github.com/apache/cassandra-analytics/pull/236#discussion_r3993228640
########## cassandra-six-zero-bridge/src/main/java/org/apache/cassandra/io/sstable/format/bti/BtiReaderUtils.java: ########## Review Comment: is it needed…? The five-zero test directory is already a second test source directory of the six-zero module, and the module's own main output precedes five-zero on the test compile classpath, so `BtiReaderUtilsTest` runs against the six-zero class; the proof is that five-zero's body calls keyReader(), which does not exist on 6.0 and would throw NoSuchMethodError. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
