michaelsembwever commented on code in PR #236:
URL:
https://github.com/apache/cassandra-analytics/pull/236#discussion_r3992557922
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/bridge/CassandraVersionFeatures.java:
##########
@@ -32,7 +34,14 @@ public class CassandraVersionFeatures implements
Comparable<CassandraVersionFeat
{
private static final Pattern VERSION_PATTERN_3 =
Pattern.compile("(?:.+-)?([0-9]+)\\.([0-9]+)\\.([0-9]+)([a-zA-Z0-9-]*)");
private static final Pattern VERSION_PATTERN_4 =
Pattern.compile("(?:.+-)?([0-9]+)\\.([0-9]+)\\.([0-9]+)\\.([0-9]+)[a-zA-Z0-9-]*");
- private static final Pattern VERSION_PATTERN_SNAPSHOT =
Pattern.compile("(?:.+-)?([0-9]+)\\.([0-9]+)-(SNAPSHOT)$");
+ // A major version carries no patch number until its first release:
cassandra-4.0-SNAPSHOT, cassandra-6.0-alpha2,
Review Comment:
added in `CassandraVersionFeaturesTest`
see
https://github.com/apache/cassandra-analytics/pull/236/changes/16d6c8fceb6fb3e535a66857e2a10f12175da2c9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
