skoppu22 commented on code in PR #222:
URL:
https://github.com/apache/cassandra-analytics/pull/222#discussion_r4047509998
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RingInstance.java:
##########
@@ -39,10 +39,22 @@ public class RingInstance implements CassandraInstance,
Serializable
private static final long serialVersionUID = 4399143234683369652L;
private RingEntry ringEntry;
private @Nullable String clusterId;
+ private @Nullable Integer sidecarInstanceId;
Review Comment:
[minor] Need to update serialVersionUID as we are adding a new param
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -126,6 +126,7 @@ public class BulkSparkConf implements Serializable
public static final String SIDECAR_REQUEST_RETRY_DELAY_MILLIS =
SETTING_PREFIX + "sidecar.request.retries.delay.milliseconds";
public static final String SIDECAR_REQUEST_MAX_RETRY_DELAY_MILLIS =
SETTING_PREFIX + "sidecar.request.retries.max.delay.milliseconds";
public static final String SIDECAR_REQUEST_TIMEOUT_SECONDS =
SETTING_PREFIX + "sidecar.request.timeout.seconds";
+ public static final String SIDECAR_INSTANCE_ID =
SETTING_PREFIX + "sidecar.instance.id";
Review Comment:
Why do we need global instance ID? Why don't we drop sidecar.instance.id,
rely on dynamic ids and the host:port=<id> suffix ? That deletes the
possibility of incorrectly using global instance ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
