bianca-stanciu29 commented on code in PR #222:
URL:
https://github.com/apache/cassandra-analytics/pull/222#discussion_r4060481549
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -126,6 +126,7 @@ public class BulkSparkConf implements Serializable
public static final String SIDECAR_REQUEST_RETRY_DELAY_MILLIS =
SETTING_PREFIX + "sidecar.request.retries.delay.milliseconds";
public static final String SIDECAR_REQUEST_MAX_RETRY_DELAY_MILLIS =
SETTING_PREFIX + "sidecar.request.retries.max.delay.milliseconds";
public static final String SIDECAR_REQUEST_TIMEOUT_SECONDS =
SETTING_PREFIX + "sidecar.request.timeout.seconds";
+ public static final String SIDECAR_INSTANCE_ID =
SETTING_PREFIX + "sidecar.instance.id";
Review Comment:
Yes, you're right, I missed this. Good catch!
I removed sidecar.instance.id and the whole global ID path, including
instanceId from HttpClientConfig and validateSidecarInstanceIdCoverage.
Routing now only uses the per-instance ID reported by Sidecar
([#380](https://github.com/apache/cassandra-sidecar/pull/380)) or the
host:port=<id> contact-point suffix as a fallback for older Sidecars.
The behavioral change is that a single instance behind a load balancer now
needs the ID on the contact point or a Sidecar that reports it dynamically.
Tests are updated accordingly. Ready for another look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
