bianca-stanciu29 commented on code in PR #222:
URL:
https://github.com/apache/cassandra-analytics/pull/222#discussion_r4229604868
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -126,6 +126,7 @@ public class BulkSparkConf implements Serializable
public static final String SIDECAR_REQUEST_RETRY_DELAY_MILLIS =
SETTING_PREFIX + "sidecar.request.retries.delay.milliseconds";
public static final String SIDECAR_REQUEST_MAX_RETRY_DELAY_MILLIS =
SETTING_PREFIX + "sidecar.request.retries.max.delay.milliseconds";
public static final String SIDECAR_REQUEST_TIMEOUT_SECONDS =
SETTING_PREFIX + "sidecar.request.timeout.seconds";
+ public static final String SIDECAR_INSTANCE_ID =
SETTING_PREFIX + "sidecar.instance.id";
Review Comment:
Hi @skoppu22, could you please take another look at the latest revision for
a +1 to merge into trunk?
Following your feedback, I removed the global sidecar.instance.id setting
and updated RingInstance.serialVersionUID. Routing now uses the target
instance's own ID, preferring Sidecar topology metadata and falling back to
explicit host[:port]=<id> contact points.
I've also updated the PR description to clarify the bulk-writer scope, the
static fallback limitations, and the dependency on apache/cassandra-sidecar#380
(CASSSIDECAR-495).
Could you confirm whether the Sidecar change should land first and whether
there are any remaining blockers to your +1?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
