[ 
https://issues.apache.org/jira/browse/CASSANDRA-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416041#comment-13416041
 ] 

Sylvain Lebresne commented on CASSANDRA-4427:
---------------------------------------------

I believe this simpler fix doesn't handle the case of boostrapping multiple 
nodes into an existing cluster. Namely, in that case, that will have a schema 
and so the node will have a system table by the time it checks for it and we'll 
end up picking the same token for multiple nodes.

Also, I think checking system tables existence is fairly fragile and I would 
prefer moving away from it. It is way too easy to screw that up by having 
something (anything) written to those system tables. Typically, I don't know if 
that fix works for multiple nodes started in a brand new cluster (with not all 
being seeds), because without careful checking I don't know if we can end up 
writing some info in the system tables before checking for getBootstrapToken.

Overall I do like the idea of registering that the bootstrap is in process, 
because on top of (I think) fixing the problem in a non-fragile way, it also 
allows us better reporting. Even outside of the problem of generating tokens, I 
think it is reassuring for a user that restart a node that failed to boostrap 
to have the software acknowledge that it understand and handle correctly the 
situation.
                
> Restarting a failed bootstrap instajoins the ring
> -------------------------------------------------
>
>                 Key: CASSANDRA-4427
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4427
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Brandon Williams
>            Assignee: Jonathan Ellis
>             Fix For: 1.0.11, 1.1.3
>
>         Attachments: 4427-v2.txt, 4427-v3.txt, 4427.txt
>
>
> I think when we made auto_bootstrap = true the default, we broke the check 
> for the bootstrap flag, creating a dangerous situation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to