[ 
https://issues.apache.org/jira/browse/CASSANDRA-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416945#comment-13416945
 ] 

Sylvain Lebresne commented on CASSANDRA-4427:
---------------------------------------------

bq. Adding "bootstrap in progress" concept does nothing for this one way or the 
other.

You're right, brain fart, sorry.

Anyway, there is still one behavior that the patch changes, that is it will 
always boobstrap non seeds node, while previously the system table check was 
making sure we never bootstrapped a node in a new cluster, independently of 
whether it was a seed or not.

It is clearly not a bad idea when you start a new cluster to set all those 
nodes as seeds, but I just want to point out that the behavior is changed and 
I'm not sure everyone always set all of its initial node as seeds today. I'll 
also note that boostrapping some of the node in an initial cluster don't break 
anything, it just makes the node start much less quickly that they would 
otherwise.

I'm not sure how I feel about changing that behavior, especially in a minor 
release. The fact is that recording that bootstrap is in progress (along with 
the system table check) would allow to fix the instajoin while keeping the 
current behavior unchanged otherwise, and I do feel that recording the info is 
not a bad idea in itself, so that would have my preference. But that is not an 
extremely strong preference either.
                
> Restarting a failed bootstrap instajoins the ring
> -------------------------------------------------
>
>                 Key: CASSANDRA-4427
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4427
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Brandon Williams
>            Assignee: Jonathan Ellis
>             Fix For: 1.0.11, 1.1.3
>
>         Attachments: 4427-v2.txt, 4427-v3.txt, 4427.txt
>
>
> I think when we made auto_bootstrap = true the default, we broke the check 
> for the bootstrap flag, creating a dangerous situation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to