[ 
https://issues.apache.org/jira/browse/CASSANDRA-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478514#comment-13478514
 ] 

Jason Brown commented on CASSANDRA-4239:
----------------------------------------

1) I'm curious as to why you removed -ks and -kspw. Admittedly, I was following 
the options we allow in the yaml for {server|client}_encryption_options.
2) Removing ThriftSSLFactory, as long as there's very little code that's 
duplicated in the guys who were using it (all the setup with 
o.a.t.t.TSSLTransportFactory), then I think there's no harm in yanking the 
extra class :).

Otherwise, LGTM.

                
> Support Thrift SSL socket
> -------------------------
>
>                 Key: CASSANDRA-4239
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4239
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: 
> 0001-CASSANDRA-4239-Support-Thrift-SSL-socket-both-to-the.patch, 
> 0001-CASSANDRA-4239-v3.patch, 0002-CASSANDRA-4239-Support-Thrift-SSL.patch
>
>
> Thrift has supported SSL encryption for a while now (THRIFT-106); we should 
> allow configuring that in cassandra.yaml

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to